Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dependency order in on_system methods #13636

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

FnControlOption
Copy link
Contributor

@FnControlOption FnControlOption commented Aug 3, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
    Fix various dependency orders homebrew-core#107194
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew audit should check depends_on order in on_linux and co.

homebrew/core/hurl has:

  on_linux do
    depends_on "[email protected]"
    depends_on "pkg-config" => :build
  end

but it should be:

  on_linux do
    depends_on "pkg-config" => :build
    depends_on "[email protected]"
  end

Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @FnControlOption! Good catch!

A test for this would be great, if possible!

@MikeMcQuaid
Copy link
Member

Great work as usual @FnControlOption!

@MikeMcQuaid MikeMcQuaid enabled auto-merge August 3, 2022 12:06
@MikeMcQuaid
Copy link
Member

(this PR is just waiting for homebrew-core to get fixed up so tap_syntax will pass)

auto-merge was automatically disabled August 3, 2022 13:34

Head branch was pushed to by a user without write access

Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks again, @FnControlOption!

@Rylan12 Rylan12 merged commit 8c8b843 into Homebrew:master Aug 3, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants